-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Skip test when Public IP is in an list #1714
base: main
Are you sure you want to change the base?
[Feature] Skip test when Public IP is in an list #1714
Conversation
Add failed and thresholds
Revert "Add failed and thresholds"
Any updates on this PR? This feature would significantly streamline my workflow. I'm currently using a custom solution, but I've been eagerly awaiting this implementation for a long time! Thank you again for working on this. |
It will need to be reviewed and tested. Due to the lack of time there is no ETA on this. Also converting to a draft, as i want to add a visual representation of the skipped tests in the graphs. THat will be done after the open PR for graphs changes is merged in. |
@svenvg93 I don't have any experience with PHP, but I'd be happy to try and help with the implementation if you think my Go and Java skills could be useful. ;) |
Appreciate the offer! I might do the graphical part in a seperate PR to make testing easier. |
@alexjustesen Any news on this PR? This would help me so much 😀 |
📃 Description
In some setups, backup connections may be metered, making speed tests on these connections potentially costly. To avoid running tests on these connections, users can specify an IP address or IP subnet in a Docker environment to skip the tests.
We will use the following lookup: icanhazip.com
If these values match any of the specified settings in the Docker environment, the test will be marked as skipped.
A test will be marked as skipped if:
To close #1111
🪵 Changelog
➕ Added
SPEEDTEST_SKIP_IP=192.168.1.1;10.0.0.0/24;172.16.0.0/16"
📷 Screenshots
Results table:
When an Single IP is Set:
When an IP Subnet is set (Still called Error message, this was changed later):