Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add possibility to pass initial admin credentials with env variables #1924

Merged

Conversation

twinpixxx
Copy link
Contributor

πŸ“ƒ Description

This PR adds possibility to pass admin credentials for initial startup. Closes #1597
Docs repo PR: alexjustesen/speedtest-tracker-docs#52

πŸͺ΅ Changelog

βž• Added

  • Environment variables

✏️ Changed

  • Initial migration in which the admin user is created
  • .env.example file

@DenuxPlays
Copy link

Wouldnt make Sense to accept and already hashed password?

Services like vaultwarden already do this because its way more Secure.

@twinpixxx
Copy link
Contributor Author

@DenuxPlays it would be overcomplicated, IMHO. By design, you (as the end user) expect the password provided in the .env file to work in the web view.
I agree that it’s more secure, but with the current implementation of user management and the process for creating the default admin password, it would feel a bit odd.

.env.example Outdated Show resolved Hide resolved
config/app.php Outdated Show resolved Hide resolved
@alexjustesen
Copy link
Owner

@twinpixxx couple of minor changes, also thank you for linking to the docs PR as well πŸ‘

@alexjustesen alexjustesen merged commit c9637ed into alexjustesen:main Dec 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure admin email/password through environment variables?
3 participants