Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Docker image builds #739

Merged
merged 12 commits into from
Sep 7, 2023
Merged

[Bugfix] Docker image builds #739

merged 12 commits into from
Sep 7, 2023

Conversation

alexjustesen
Copy link
Owner

@alexjustesen alexjustesen commented Sep 7, 2023

Description

This PR is intended to separate the builds for release and prerelease tags so that latest isn't used when a non-stable release is tagged. This PR also aligns image tagging to Semver standards.

Tag definitions

  • latest is the latest stable production build from the latest tagged release.
  • x.x.x are a history of stable production builds that correspond to that tagged release.
  • x.x.x-beta/alpha are potentially unstable builds from the latest tagged prerelease. Going forward these will also not update the latest build tag.

Changelog

Added

  • ci.yml to ensure Docker builds are successful prior to release-** branches being merged

Changed

  • combined Docker Hub and GHCR builds into a single workflow
  • use push tags for cd.yml trigger event instead of release tag

Fixed

  • use semver image tagging, docs

@alexjustesen alexjustesen added the 🐛 bug Something isn't working label Sep 7, 2023
@alexjustesen alexjustesen self-assigned this Sep 7, 2023
@corasaniti
Copy link

@alexjustesen
Great job buddy!!! :-) So, now if I pull the latest tag I get 0.11.22? Right?
Where can I see the tag list?
Thanks in advance

@alexjustesen
Copy link
Owner Author

@alexjustesen Great job buddy!!! :-) So, now if I pull the latest tag I get 0.11.22? Right? Where can I see the tag list? Thanks in advance

Still working on it and will have to post a new latest but you can always check the history of builds on the registries:

@alexjustesen alexjustesen marked this pull request as ready for review September 7, 2023 13:28
@alexjustesen alexjustesen merged commit 6f70bad into main Sep 7, 2023
2 checks passed
@alexjustesen alexjustesen deleted the bugfix-docker-image-builds branch September 7, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants