-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Docker image builds #739
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@alexjustesen |
Still working on it and will have to post a new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is intended to separate the builds for
release
andprerelease
tags so thatlatest
isn't used when a non-stable release is tagged. This PR also aligns image tagging to Semver standards.Tag definitions
latest
is the latest stable production build from the latest tagged release.x.x.x
are a history of stable production builds that correspond to that tagged release.x.x.x-beta/alpha
are potentially unstable builds from the latest tagged prerelease. Going forward these will also not update thelatest
build tag.Changelog
Added
ci.yml
to ensure Docker builds are successful prior torelease-**
branches being mergedChanged
cd.yml
trigger event instead of release tagFixed