Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Getting ready for Ember 4 #765

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Baltazore
Copy link

@Baltazore Baltazore commented Oct 17, 2022

I tried to do #690 twice last week, both times I failed due to crashes in test-app and later in docs-app

I noticed that for my app I mostly needed this add-on to be up to date with its internal dependencies, but also wanted to at least update docs ( they are few versions behind now )

This is still WIP, but I want to show progress, and get feedback sooner.

TODO:

  • Fix Deprecation for service:fastboot
DEPRECATION: As of Ember 4.0.0, owner.inject no longer injects values into resolved instances, and calling the method has been deprecated. Since this method no longer does anything, it is fully safe to remove this injection. As an alternative to this API, you can refactor to explicitly inject `_fastbootInfo` on `service:fastboot`, or look it up directly using the `getOwner` API. [deprecation id: remove-owner-inject] See https://deprecations.emberjs.com/v4.x#toc_implicit-injections for more details.
  • Fix assert.expectAssertion is not a function
    From what I see the addon is not maintained anymore, not sure what to do with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant