Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate PGN format wrong when first move is black to play #78

Merged
merged 2 commits into from
Apr 24, 2024
Merged

generate PGN format wrong when first move is black to play #78

merged 2 commits into from
Apr 24, 2024

Conversation

govind-maheshwari2
Copy link
Contributor

@govind-maheshwari2 govind-maheshwari2 commented Apr 23, 2024 •
edited
Loading

Current output

[FEN "rnbqkbnr/pppppppp/8/8/8/8/PPPPPPPP/RN2K2R b KQkq - 0 1"]
1. ..d6 1. O-O

Expected Output

[FEN "rnbqkbnr/pppppppp/8/8/8/8/PPPPPPPP/RN2K2R b KQkq - 0 1"]
1... d6 2. O-O

Output after fix:

[FEN "rnbqkbnr/pppppppp/8/8/8/8/PPPPPPPP/RN2K2R b KQkq - 0 1"]
1... d6 2. O-O

Parsing getting fail because of this.

alexobviously
alexobviously approved these changes Apr 24, 2024
View reviewed changes
Copy link
Owner

@alexobviously alexobviously left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, I hadn't thought of this case

@alexobviously alexobviously merged commit 70d9ff6 into alexobviously:master Apr 24, 2024
1 check passed
@govind-maheshwari2
Copy link
Contributor Author

govind-maheshwari2 commented Apr 24, 2024 •
edited
Loading

@alexobviously When are you planning to make a release with this change?

@alexobviously
Copy link
Owner

@alexobviously When are you planning to make a release with this change?

I'm publishing a release tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexobviously alexobviously alexobviously approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@govind-maheshwari2 @alexobviously