📝 subscriber: Add some more TODOs for future me

alexocode · Jan 12, 2024 · 5971ad9 · 5971ad9
1 parent ccdfacb
commit 5971ad9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/TODO b/TODO
@@ -1,4 +1,5 @@
 Batching:
+  ☐ Introduce a Subscriber.Simple behaviour that is used by the generated default implementation
   ☐ Refactor Subscriber.Generic to handle batching
   ☐ Refactor Adapter.Local to send batched messages
 

diff --git a/lib/gazet/subscriber.ex b/lib/gazet/subscriber.ex
@@ -146,6 +146,7 @@ defmodule Gazet.Subscriber do
 
       @impl Gazet.Subscriber
       def handle_batch(topic, batch, context) do
+        # TODO: Refactor this to rely on a `Subscriber.Simple` behaviour
         Enum.reduce_while(batch, :ok, fn {message, metadata}, _ ->
           with {:error, reason} <- handle_message(topic, message, metadata, context),
                {:error, reason} <- handle_error(reason, topic, message, metadata, context) do