Issue when false was forced to have single quotes around it breaking …

…it from being false. I removed that default from all values.
alfred-nutile-inc · Dec 6, 2015 · 359695c · 359695c
1 parent 4546861
commit 359695c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/BuildArrayFromEnv.php b/src/BuildArrayFromEnv.php
@@ -77,7 +77,7 @@ protected function swapTokenIntoTarget($token, $target)
         if(is_numeric($value_from_token))
             return sprintf("%s=%d", $target_key_value_removed, $value_from_token);
 
-        return sprintf("%s='%s'", $target_key_value_removed, $value_from_token);
+        return sprintf("%s=%s", $target_key_value_removed, $value_from_token);
     }
 
     protected function stripStartingTags($value)

diff --git a/tests/BuildArrayFromEnvTest.php b/tests/BuildArrayFromEnvTest.php
@@ -30,7 +30,7 @@ public function should_reduce_to_target_values()
         $ba->setEnv(["#@dev=bar", "#@stage=foo", "APP_ENV=local"]);
         $ba->buildOutNewEnvArray();
 
-        $this->assertEquals('APP_ENV=\'bar\'', $ba->getTargetEnv()[0]);
+        $this->assertEquals('APP_ENV=bar', $ba->getTargetEnv()[0]);
         $this->assertCount(1, $ba->getTargetEnv());
     }
 
@@ -43,7 +43,7 @@ public function should_include_default_settings_as_well_not_just_replaced_ones()
         $ba->setEnv(["#@dev=bar", "#@stage=foo", "APP_ENV=local", "FOO_BAR='foo'"]);
         $ba->buildOutNewEnvArray();
 
-        $this->assertEquals('APP_ENV=\'bar\'', $ba->getTargetEnv()[0]);
+        $this->assertEquals('APP_ENV=bar', $ba->getTargetEnv()[0]);
         $this->assertEquals('FOO_BAR=\'foo\'', $ba->getTargetEnv()[1]);
         $this->assertCount(2, $ba->getTargetEnv());
     }
@@ -83,9 +83,9 @@ public function larger_set_prove_working()
             ]);
         $ba->buildOutNewEnvArray();
 
-        $this->assertEquals('APP_ENV=\'bar\'', $ba->getTargetEnv()[0]);
+        $this->assertEquals('APP_ENV=bar', $ba->getTargetEnv()[0]);
         $this->assertEquals('FOO_BAR=\'foo\'', $ba->getTargetEnv()[1]);
-        $this->assertEquals('FOO_BAR2=\'bar2\'', $ba->getTargetEnv()[2]);
+        $this->assertEquals('FOO_BAR2=bar2', $ba->getTargetEnv()[2]);
         $this->assertCount(3, $ba->getTargetEnv());
     }
 
@@ -107,9 +107,9 @@ public function larger_set_prove_working_stage()
             ]);
         $ba->buildOutNewEnvArray();
 
-        $this->assertEquals('APP_ENV=\'foo\'', $ba->getTargetEnv()[0]);
+        $this->assertEquals('APP_ENV=foo', $ba->getTargetEnv()[0]);
         $this->assertEquals('FOO_BAR=\'foo\'', $ba->getTargetEnv()[1]);
-        $this->assertEquals('FOO_BAR2=\'bar3\'', $ba->getTargetEnv()[2]);
+        $this->assertEquals('FOO_BAR2=bar3', $ba->getTargetEnv()[2]);
         $this->assertCount(3, $ba->getTargetEnv());
     }