Expose text field background / foreground colors to enable dark mode support #234
+15
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msmollin
changed the title
|
Hi @msmollin ,
The Xcode project file is there only for Carthage support, you did right using the
I have no issue in Xcode 13.4.1. Did you try it on another machine? Could you also provide a snippet of how you consider to use these parameters in a real SwiftUI view? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The text field background and foreground color for the main search bar component is not dark mode aware, so this PR exposes them for 3rd party developers to override and customize.
Result
The Xcode project in this repository seems to require special local configuration in order to build from the project file, so I opened the
Package.swiftfile and made sure the changes built using the package declarations (which it did).Also I made a minor update to specify the generic type of the button label in order to satisfy Swift's compiler in Xcode 13.4.1 which could not figure out the Button's label type. If you find this unnecessary I'm happy to remove it.