fix: patching algosdkv3 compatibility issues #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilcampbell
reviewed
Jan 6, 2025
src/utils.ts
Outdated
| function parseAlgosdkV2SimulateResponse(obj: any): any { | ||
| if (obj === null || typeof obj !== 'object') return obj | ||
|
|
||
| const addressFields = new Set(['snd', 'close', 'aclose', 'rekey', 'rcv', 'arcv', 'fadd', 'asnd']) |
There was a problem hiding this comment.
There are a couple of other fields like 'm', 'r', 'f', 'c'. Maintenance of this code isn't going to be great, for example we'll need to add block proposer "prp". I don't have any other great options though and we are doing similar things in multiple repos algorandfoundation/algokit-subscriber-ts#102 (comment)
There was a problem hiding this comment.
@neilcampbell pushed a commit adding extra fields, incluing the 'prp'
aorumbayev
force-pushed
the
fix/algosdkv3
branch
from
a98003c to
8dd208a
Compare
aorumbayev
force-pushed
the
fix/algosdkv3
branch
from
8dd208a to
6296626
Compare
neilcampbell
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - #52, #51
Proposed changes
Tested against simulate traces from v6 utils + v2 algosdk and v8 utils + v3 algosdk (as per bug descriptions in issues above)