-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resource population bugs #278
Conversation
@robdmoore We're seeing the indexer tests timeout and I'm also seeing the same locally since I've updated my localnet. I know we've talked about this before but forget what the reasoning was and how we might reasonably fix this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, keep in mind i'm missing most of the context of these changes. The changes themselves look good though
There's some quite complex logic here that it may make sense to have test coverage for, but on the other hand I know this logic will move to algod at some point so probably time better spent adding test coverage there when that happens? |
41bbfbe
to
1d2ce1f
Compare
Yeah that's exactly what I'm thinking. Will start algod effort this week so didn't want to spend time writing the tests here. I've confirmed that this works in the reti ui. |
Proposed Changes
Fixes two bugs on resource population
Pushing a resource to an undefined array doesn't actually work
Box references weren't checking if the app was available