Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lsig examples #2

Merged

Conversation

CiottiGiorgio
Copy link
Member

No description provided.

and Txn.rekey_to == Global.zero_address
and Txn.close_remainder_to == Global.zero_address
and Txn.fee == 2 * Global.min_txn_fee
and Txn.last_valid <= TemplateVar[UInt64]("EXPIRATION_ROUND")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't a lease needed here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal of the example is how you can provide fees for all calls to an app as a Contract Account.

I don't think so? Every call to this dummy app is legit. And if the same app call is replayed, then it will be rejected by the same TxID, right?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, so the trust model completely relies on the App validation. I was just wondering if some users could "abuse" the Contract's fund or not. But I guess it the App duty to guard against those.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes exactly.

Copy link
Collaborator

@iskysun96 iskysun96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CiottiGiorgio CiottiGiorgio merged commit 65be1bf into algorandfoundation:main Oct 21, 2024
1 check passed
@CiottiGiorgio CiottiGiorgio deleted the feat/lsig-examples branch October 21, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants