Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace requestId double with UUID v7 #19

Merged
merged 2 commits into from
Jul 22, 2024
Merged

feat: replace requestId double with UUID v7 #19

merged 2 commits into from
Jul 22, 2024

Conversation

kylebeee
Copy link
Collaborator

@kylebeee kylebeee commented Jul 15, 2024 •
edited by PhearZero
Loading

ℹ Overview

  • switched requestId from double to uuid v7 based string

📝 Related Issues

✅ Acceptance:

  • Conventional Commits

@kylebeee kylebeee changed the title chore: replaced requestId with UUID v7 chore: replaced requestId double with UUID v7 Jul 15, 2024
@kylebeee kylebeee requested a review from PhearZero July 15, 2024 07:33
PhearZero
PhearZero reviewed Jul 16, 2024
View reviewed changes
Copy link
Member

@PhearZero PhearZero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests are failing in the CI/CD

@kylebeee kylebeee changed the title chore: replaced requestId double with UUID v7 feat: replace requestId double with UUID v7 Jul 17, 2024
@kylebeee kylebeee force-pushed the chore/switch-request-id-to-uuid branch from 73bf4ac to ee3a95a Compare July 17, 2024 23:33
@PhearZero PhearZero self-requested a review July 22, 2024 18:50
PhearZero
PhearZero approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@PhearZero PhearZero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhearZero PhearZero merged commit c4c55cc into develop Jul 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhearZero PhearZero PhearZero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylebeee @PhearZero