Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix utils module not found #96

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix utils module not found #96

wants to merge 3 commits into from

Conversation

BeingGod
Copy link

Fix utils module not found bug when doing huggingface to megatron-lm model convert.

image

@CLAassistant
Copy link

CLAassistant commented Sep 24, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@BeingGod
Copy link
Author

PTAL @SeaOfOcean

@SeaOfOcean
Copy link
Collaborator

@BeingGod thanks for the pr, you need to sign the license/cla first

@BeingGod BeingGod closed this Sep 24, 2024
@BeingGod BeingGod reopened this Sep 24, 2024
@BeingGod
Copy link
Author

BeingGod commented Sep 24, 2024 •
edited
Loading

@BeingGod thanks for the pr, you need to sign the license/cla first

It looks like that I meet a problem. CLA signed page show that I have already signed CLA.
image

What should I do now？

adoda
adoda previously approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@adoda adoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adoda
Copy link
Collaborator

adoda commented Sep 24, 2024

@BeingGod thanks for the pr, you need to sign the license/cla first

It looks like that I meet a problem. CLA signed page show that I have already signed CLA. image

What should I do now？

image

@BeingGod
Copy link
Author

@BeingGod thanks for the pr, you need to sign the license/cla first

It looks like that I meet a problem. CLA signed page show that I have already signed CLA. image
What should I do now？

image

Done.

@SeaOfOcean
Copy link
Collaborator

what‘s the docker image you use to reproduce the error? @BeingGod

@BeingGod
Copy link
Author

what‘s the docker image you use to reproduce the error? @BeingGod

My docker was built by https://github.com/alibaba/ChatLearn/blob/main/docker/torch/Dockerfile.torch2.3.0 .

haolin-nju
haolin-nju approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@haolin-nju haolin-nju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for the late review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adoda adoda adoda left review comments

@haolin-nju haolin-nju haolin-nju approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BeingGod @CLAassistant @SeaOfOcean @adoda @haolin-nju