mobilevit model v0.01 #120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenmengzhou
reviewed
Jul 13, 2022
|
|
||
| """ | ||
|
|
||
| def __init__(self, |
There was a problem hiding this comment.
这种layer为什么不直接用nn.Dropout？ 同其他layer
wenmengzhou
reviewed
Jul 13, 2022
| self.logger = get_root_logger() | ||
|
|
||
| @classmethod | ||
| def add_arguments(cls, parser: argparse.ArgumentParser): |
wenmengzhou
reviewed
Jul 13, 2022
| This class defines the MobileViTv2 architecture | ||
| """ | ||
|
|
||
| def __init__(self, *args, **kwargs) -> None: |
There was a problem hiding this comment.
请参考其他backbone把主要参数在__init__函数中声明
wenmengzhou
reviewed
Jul 13, 2022
| self.reset_parameters(opts=opts) | ||
|
|
||
| @classmethod | ||
| def add_arguments( |
wenmengzhou
reviewed
Jul 13, 2022
| print('-' * 67) | ||
| return input, overall_params, overall_macs | ||
|
|
||
| def profile_model( |
wenmengzhou
reviewed
Jul 13, 2022
| return nn.Sequential(*block), input_channel | ||
|
|
||
|
|
||
| def MobileViTv2_postprocess(out): |
There was a problem hiding this comment.
这个可以抽象到forward_test接口里，放到主干网络里
jhuang1207
reviewed
Jul 15, 2022
| @@ -0,0 +1 @@ | |||
| from .mobilevit_v2 import MobileViTv2, MobileViTv2_postprocess | |||
There was a problem hiding this comment.
mobilevit为什么要单独开个目录，这个不符合之前的代码结构风格。beckbone，heads等抽象需要放到对应的目录里
jhuang1207
reviewed
Jul 15, 2022
| @@ -0,0 +1,82 @@ | |||
| # | |||
There was a problem hiding this comment.
这个layers目录是干啥的？看起来就是把官方代码抄了一份过来？这个完全没有按照EasyCV本身的设计理念进行开发。这个大的代码结构的调整，必须有详细的设计文档，以及调整的理由
jhuang1207
reviewed
Jul 15, 2022
|
|
||
|
|
||
| __all__ = [ | ||
| 'GELU', |
There was a problem hiding this comment.
relu，sigmoid等等，原util文件夹下本来就有，activation乃至layers文件夹存在的意义是什么？
jhuang1207
reviewed
Jul 15, 2022
| return parser | ||
|
|
||
|
|
||
| __all__ = [ |
jhuang1207
requested changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.