Skip to content

Commit

Permalink
fix(interactive): Fix Interactive CI (#4335)
Browse files Browse the repository at this point in the history
Use a fixed `openapi-generator` version to make codegen repeatable.

Related CI failure:
https://github.com/alibaba/GraphScope/actions/runs/11948608684/job/33307061458
  • Loading branch information
zhanglei1949 authored Nov 22, 2024
1 parent cd4a6cd commit 94a02d7
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
3 changes: 1 addition & 2 deletions flex/interactive/sdk/generate_sdk.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ DEVELOPER_NAME="GraphScope Team"
LICENSE_NAME="Apache-2.0"
LICENSE_URL="https://www.apache.org/licenses/LICENSE-2.0.html"
LOG_LEVEL="error"

export OPENAPI_GENERATOR_VERSION=7.2.0

#get current bash scrip's directory
CUR_DIR=$(cd `dirname $0`; pwd)
Expand Down Expand Up @@ -129,7 +129,6 @@ function install_generator() {
curl https://raw.githubusercontent.com/OpenAPITools/openapi-generator/master/bin/utils/openapi-generator-cli.sh > ~/bin/openapitools/openapi-generator-cli
chmod u+x ~/bin/openapitools/openapi-generator-cli
export PATH=$PATH:~/bin/openapitools/
export OPENAPI_GENERATOR_VERSION=7.2.0
fi
# on ubuntu apt-get jq on mac brew install jq

Expand Down
4 changes: 2 additions & 2 deletions flex/interactive/sdk/python/gs_interactive/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -477,5 +477,5 @@ def update_procedure(sess: Session, graph_id: str, proc_id: str, desc: str):
def start_service_on_graph(interactive_session, graph_id: str):
resp = interactive_session.start_service(StartServiceRequest(graph_id=graph_id))
assert resp.is_ok()
# wait one second to let compiler get the new graph
time.sleep(1)
# wait three second to let compiler get the new graph
time.sleep(3)
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,3 @@ def test_custom_pk_name(
records = result.fetch(1)
assert len(records) == 1 and records[0]["$f0"] == 2
start_service_on_graph(interactive_session, "1")
sleep(
3
) # sleep for a while to make sure the compiler has updated to the new schema

0 comments on commit 94a02d7

Please sign in to comment.