Skip to content

Commit

Permalink
fixing
Browse files Browse the repository at this point in the history
Committed-by: xiaolei.zl from Dev container
  • Loading branch information
zhanglei1949 committed Oct 28, 2024
1 parent 91fcabe commit a6f04fa
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 21 deletions.
18 changes: 0 additions & 18 deletions flex/engines/graph_db/database/wal.h
Original file line number Diff line number Diff line change
Expand Up @@ -80,17 +80,6 @@ class IWalWriter {
virtual void open(const std::string& path, int thread_id) = 0;
virtual void close() = 0;
virtual IWalWriter::WalWriterType type() const = 0;
/**
* @brief Append the data to the WAL.
* The published messages contains these info.
* 1. The thread id
* 2. The timestamp of the message(could be deemed as the id of WAL).
* 3. The data(The WAL content).
*
* @param data The data to be sent
* @param length The length of the data
*
*/
virtual bool append(const char* data, size_t length) = 0;
};

Expand All @@ -102,11 +91,8 @@ class LocalWalWriter : public IWalWriter {
~LocalWalWriter() { close(); }

void open(const std::string& path, int thread_id) override;

void close() override;

bool append(const char* data, size_t length) override;

IWalWriter::WalWriterType type() const override;

private:
Expand All @@ -127,11 +113,8 @@ class KafkaWalWriter : public IWalWriter {
~KafkaWalWriter() { close(); }

void open(const std::string& kafka_topic, int thread_id) override;

void close() override;

bool append(const char* data, size_t length) override;

IWalWriter::WalWriterType type() const override;

private:
Expand Down Expand Up @@ -229,7 +212,6 @@ class KafkaWalConsumer {
std::string poll();

private:
bool running;
std::vector<std::unique_ptr<cppkafka::Consumer>> consumers_;
std::priority_queue<std::string, std::vector<std::string>, CustomComparator>
message_queue_;
Expand Down
6 changes: 3 additions & 3 deletions python/graphscope/gsctl/scripts/install_deps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -853,9 +853,9 @@ install_analytical_java_dependencies() {
fi
}

INTERACTIVE_MACOS=("apache-arrow" "rapidjson" "boost" "glog" "gflags")
INTERACTIVE_UBUNTU=("rapidjson-dev" "libgoogle-glog-dev" "libgflags-dev")
INTERACTIVE_CENTOS=("rapidjson-devel")
INTERACTIVE_MACOS=("apache-arrow" "rapidjson" "boost" "glog" "gflags", "librdkafka")

Check warning on line 856 in python/graphscope/gsctl/scripts/install_deps.sh

View check run for this annotation

codefactor.io / CodeFactor

python/graphscope/gsctl/scripts/install_deps.sh#L856

Use spaces, not commas, to separate array elements. (SC2054)
INTERACTIVE_UBUNTU=("rapidjson-dev" "libgoogle-glog-dev" "libgflags-dev", "librdkafka-dev")

Check warning on line 857 in python/graphscope/gsctl/scripts/install_deps.sh

View check run for this annotation

codefactor.io / CodeFactor

python/graphscope/gsctl/scripts/install_deps.sh#L857

Use spaces, not commas, to separate array elements. (SC2054)
INTERACTIVE_CENTOS=("rapidjson-devel", "librdkafka-devel")

Check warning on line 858 in python/graphscope/gsctl/scripts/install_deps.sh

View check run for this annotation

codefactor.io / CodeFactor

python/graphscope/gsctl/scripts/install_deps.sh#L858

Use spaces, not commas, to separate array elements. (SC2054)

install_interactive_dependencies() {
# dependencies package
Expand Down

0 comments on commit a6f04fa

Please sign in to comment.