Skip to content

Commit

Permalink
fix: codecov uploading problem (#4257)
Browse files Browse the repository at this point in the history
  • Loading branch information
lidongze0629 authored Sep 25, 2024
1 parent b8523f9 commit f7044f9
Show file tree
Hide file tree
Showing 7 changed files with 23 additions and 18 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/flex-interactive.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,9 @@ jobs:
gsctl instance destroy --type interactive -y
- name: Upload Coverage
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
continue-on-error: true
with:
file: ./coverage.xml
fail_ci_if_error: false
files: ./coverage.xml
token: ${{ secrets.CODECOV_TOKEN }}
verbose: true
5 changes: 3 additions & 2 deletions .github/workflows/gae.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,5 +92,6 @@ jobs:
uses: codecov/codecov-action@v4
continue-on-error: true
with:
file: ./python/coverage.xml
fail_ci_if_error: false
files: ./python/coverage.xml
token: ${{ secrets.CODECOV_TOKEN }}
verbose: true
5 changes: 3 additions & 2 deletions .github/workflows/k8s-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -501,8 +501,9 @@ jobs:
uses: codecov/codecov-action@v4
continue-on-error: true
with:
file: ./python/coverage.xml
fail_ci_if_error: false
files: ./python/coverage.xml
token: ${{ secrets.CODECOV_TOKEN }}
verbose: true

- name: HDFS test
if: false # FIXME(siyuan): Open this test
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/local-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ jobs:
- 'python/graphscope/framework/**'
- 'python/graphscope/tests/unittest/**'
- 'coordinator/gscoordinator/**'
- '.github/workflows/ci.yml'
- '.github/workflows/local-ci.yml'
networkx:
- 'analytical_engine/apps/**'
- 'analytical_engine/frame/**'
Expand Down Expand Up @@ -329,8 +329,8 @@ jobs:

python-unittest:
runs-on: ubuntu-20.04
needs: [build-wheels, changes]
if: ${{ github.repository == 'alibaba/GraphScope' }}
needs: [build-wheels, changes]
defaults:
run:
shell: bash --noprofile --norc -eo pipefail {0}
Expand Down Expand Up @@ -390,12 +390,12 @@ jobs:
$(dirname $(python3 -c "import graphscope; print(graphscope.__file__)"))/tests/unittest
- name: Upload Coverage
if: ${{ needs.changes.outputs.gae-python == 'true' || github.ref == 'refs/heads/main' }}
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
continue-on-error: true
with:
file: ./coverage.xml
fail_ci_if_error: false
files: ./coverage.xml
token: ${{ secrets.CODECOV_TOKEN }}
verbose: true

networkx-basic-test:
runs-on: ubuntu-20.04
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,10 @@ jobs:
make unittest
- name: Upload Coverage
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
if: matrix.os == 'ubuntu-20.04'
continue-on-error: true
with:
file: ./python/coverage.xml
fail_ci_if_error: false
files: ./python/coverage.xml
token: ${{ secrets.CODECOV_TOKEN }}
verbose: true
3 changes: 2 additions & 1 deletion python/graphscope/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@
class ResourceSpec:
"""Resource requirements for a container in kubernetes."""

cpu: Union[str, float, None] = None # CPU cores of container.
# CPU cores of container.
cpu: Union[str, float, None] = None
# Memory of container, suffix with ['Mi', 'Gi', 'Ti'].
memory: Union[str, None] = None

Expand Down
2 changes: 1 addition & 1 deletion python/graphscope/gsctl/commands/dev.py
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ def deploy(
Interactive service is ready, you can connect to the interactive service with interactive sdk:
Interactive Admin service is listening at
http://127.0.0.1{admin_port},
http://127.0.0.1:{admin_port},
You can connect to admin service with Interactive SDK, with following environment variables declared.
############################################################################################
Expand Down

0 comments on commit f7044f9

Please sign in to comment.