Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Reorg the building of openapi-related code #4481

Merged
merged 10 commits into from
Feb 12, 2025

Conversation

zhanglei1949
Copy link
Collaborator

@zhanglei1949 zhanglei1949 commented Feb 11, 2025

Note that although coordinator's flex-related code could also be generated when needed, but we still preserve them in the code base for reference.

Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Copy link
Contributor

github-actions bot commented Feb 11, 2025

Please check the preview of the documentation changes at
https://dff1b814.graphscope-docs-preview.pages.dev

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.65%. Comparing base (7b8a4aa) to head (78c3587).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #4481       +/-   ##
===========================================
+ Coverage   33.10%   62.65%   +29.54%     
===========================================
  Files         126      127        +1     
  Lines       13265    13291       +26     
===========================================
+ Hits         4392     8327     +3935     
+ Misses       8873     4964     -3909     
Files with missing lines Coverage Δ
python/graphscope/analytical/udf/compile.py 91.29% <ø> (+66.39%) ⬆️
python/graphscope/analytical/udf/patch.py 100.00% <ø> (+97.36%) ⬆️
python/graphscope/client/connection.py 35.25% <ø> (ø)
python/graphscope/client/session.py 67.39% <ø> (+11.20%) ⬆️
python/graphscope/config.py 75.56% <ø> (+0.75%) ⬆️
python/graphscope/framework/dag.py 84.53% <ø> (+3.09%) ⬆️
python/graphscope/framework/operation.py 87.50% <ø> (+11.11%) ⬆️

... and 70 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b8a4aa...78c3587. Read the comment docs.

Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
lidongze0629
lidongze0629 previously approved these changes Feb 12, 2025
Committed-by: xiaolei.zl from Dev container
@zhanglei1949 zhanglei1949 merged commit 1211ee1 into alibaba:main Feb 12, 2025
31 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align Coordinator's DataType with Interactive's DataType. Introducing var_char in coordinator
5 participants