semaphore plus #667
Merged
semaphore plus #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beef9999
reviewed
Dec 17, 2024
lihuiba
commented
Dec 18, 2024
thread/thread.cpp
Outdated
| auto cnt = m_count.fetch_add(count) + count; | ||
| if (!q.th) return 0; | ||
| if (cnt >= q.th->semaphore_count) { | ||
| do_resume: resume_one(); |
There was a problem hiding this comment.
The following loop depends on the condition that q.th has been checked. The loop starts from the 2nd element, and uses q.th as the end.
lihuiba
force-pushed
the
semaphore_plus
branch
3 times, most recently
from
405c401 to
e7eff91
Compare
(1) add an option for in-order resume of threads (by default not); (2) avoid thundering herd of threads whose needs are not met;
lihuiba
force-pushed
the
semaphore_plus
branch
from
e7eff91 to
0e36bb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) add an option for in-order resume of threads (by default not);
(2) avoid thundering herd of threads whose needs are not met;