iouring sq poll and io poll #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihuiba
force-pushed
the
iouring_kernel_poll
branch
4 times, most recently
from
8dfb1df to
0fff281
Compare
beef9999
reviewed
Dec 24, 2024
io/iouring-wrapper.cpp
Outdated
| int ret = io_uring_submit(m_ring); | ||
| if (ret < 0) | ||
| LOG_ERROR_RETURN(-ret, -1, "iouring: fail to submit when adding interest, ", ERRNO(-ret)); | ||
|
|
There was a problem hiding this comment.
We used to only submit IO in the reap process, in order to reduce the number of syscalls.
Will it cause performance decline?
There was a problem hiding this comment.
We already have it in add_interest() and rm_interest(). It might be missing here?
beef9999
reviewed
Dec 24, 2024
photon.h
Outdated
| #endif | ||
|
|
||
| #undef SHIFT | ||
|
|
||
| struct PhotonOptions { | ||
| int libaio_queue_depth = 32; | ||
| uint32_t iouring_sq_thread_cpu; | ||
| uint32_t iouring_sq_thread_idle = 1000; // by default polls for 1s |
There was a problem hiding this comment.
Rename to iouring_sq_thread_idle_ms ?
lihuiba
force-pushed
the
iouring_kernel_poll
branch
from
0fff281 to
3026e27
Compare
lihuiba
force-pushed
the
iouring_kernel_poll
branch
from
3026e27 to
f4fcf35
Compare
beef9999
reviewed
Dec 25, 2024
| make_named_value("setup_sq_aff", args.setup_sq_aff), | ||
| make_named_value("sq_thread_cpu", args.sq_thread_cpu)); | ||
| auto uring = NewObj<iouringEngine>() -> init(args); | ||
| if (args.is_master) return uring; |
There was a problem hiding this comment.
uring's type is MasterEventEngine* ? Don't need to do conversion?
There was a problem hiding this comment.
no need for the 1st parent class
beef9999
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.