Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crc64_with_avx512 #703

Merged
merged 1 commit into from
Feb 7, 2025
Merged

crc64_with_avx512 #703

merged 1 commit into from
Feb 7, 2025
+319 −170

Conversation

lihuiba
Copy link
Collaborator

@lihuiba lihuiba commented Jan 31, 2025 •
edited
Loading

Intel(R) Xeon(R) Platinum 8369B CPU @ 2.70GHz 128KB Data (Cached) 1GB Data (Non-Cached)
AVX512-cpp 48.47 GB/s 13.88 GB/s
SSE-cpp 25.86 GB/s 12.23 GB/s
SSE-asm 25.81 GB/s 11.99 GB/s
AMD EPYC 9T24 @ 3.6GHz 128KB Data (Cached) 1GB Data (Non-Cached)
AVX512-cpp 54.45 GB/s 29.51 GB/s
SSE-asm 13.65 GB/s 13.47 GB/s

@lihuiba lihuiba requested review from beef9999 and Coldwings January 31, 2025 07:54
beef9999
beef9999 reviewed Jan 31, 2025
View reviewed changes
CMakeLists.txt Outdated
@@ -86,7 +86,7 @@ if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
endif()

if (${ARCH} STREQUAL x86_64)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -msse4.2 -mpclmul")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -msse4.2 -mpclmul -march=native")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this change brings portability issues? native arch will enable all CPU features that the local host have.

Maybe we can add a new build option, for example PORTABLE=false

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to specific flags

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to optional specific flags

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the flags

@lihuiba lihuiba force-pushed the crc64_with_avx512 branch 24 times, most recently from c6f2b56 to 18d23ea Compare February 6, 2025 13:34
@lihuiba lihuiba requested a review from beef9999 February 6, 2025 13:42
@lihuiba lihuiba force-pushed the crc64_with_avx512 branch 2 times, most recently from 4b395b8 to 3460f1e Compare February 6, 2025 14:51
@lihuiba lihuiba force-pushed the crc64_with_avx512 branch 3 times, most recently from 981860c to 6cf4345 Compare February 6, 2025 14:58
@lihuiba lihuiba merged commit 984e7b6 into alibaba:main Feb 7, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Coldwings Coldwings Coldwings approved these changes

@beef9999 beef9999 Awaiting requested review from beef9999

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lihuiba @beef9999 @Coldwings