[build] Enable ci #149
Merged
[build] Enable ci #149
+280
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
luoyuxia
commented
Dec 9, 2024
| // less value will be popped first | ||
| int res = Integer.compare(req2.getPriority(), req1.getPriority()); | ||
| // if priority is same, we want to keep FIFO | ||
| if (res == 0 && req1 != req2) { |
There was a problem hiding this comment.
The previous implementation is not FIFO, we need to change it to FIFO
luoyuxia
commented
Dec 9, 2024
| @@ -116,7 +116,7 @@ void testRestore() throws Exception { | |||
| final int leaderServer = FLUSS_CLUSTER_EXTENSION.waitAndGetLeader(tableBucket); | |||
| Replica replica = FLUSS_CLUSTER_EXTENSION.waitAndGetLeaderReplica(tableBucket); | |||
|
|
|||
| int recordsNum = 3000; | |||
| int recordsNum = 10000; | |||
There was a problem hiding this comment.
3000 may not enough
luoyuxia
commented
Dec 9, 2024
| @@ -142,6 +144,11 @@ public void afterEach(ExtensionContext extensionContext) { | |||
| for (String database : databases) { | |||
| if (!database.equals(defaultDb)) { | |||
| metaDataManager.dropDatabase(database, true, true); | |||
| // delete the data dirs | |||
| for (int serverId : tabletServers.keySet()) { | |||
There was a problem hiding this comment.
need to delete data dirs, otherwise, restart a server will meet problem since the metadata is dropped.
|
@wuchong enable ci pr ready |
wuchong
reviewed
Dec 9, 2024
| @@ -101,6 +102,7 @@ void testAppendOnly() throws Exception { | |||
|
|
|||
| @ParameterizedTest | |||
| @ValueSource(booleans = {true, false}) | |||
| @Disabled("TODO, fix me in #116") | |||
There was a problem hiding this comment.
Will this be fixed in followup PR?
There was a problem hiding this comment.
Yes, and there're still some unstable tests need to be fixed in followup pr
| List<RpcRequest> rpcRequests = new ArrayList<>(); | ||
| // push rpc requests | ||
| for (int i = 0; i < 100; i++) { | ||
| RpcRequest rocRequest = |
wuchong
approved these changes
Dec 10, 2024
|
Ci pass...Merging.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Enable ci for fluss
Tests
N/A
API and Format
N/A
Documentation
N/A