Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dist] Deploy fluss-dist package with start scripts and config files included #184

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

wuchong
Copy link
Member

@wuchong wuchong commented Dec 14, 2024

Purpose

Package start shell scripts and config files into the fluss-dist jar package, and deploy fluss-dist to maven central when releasing. This allows companies to directly use the source code of shell scripts and config files and package their own enterprise Fluss distribution by extracting the scripts and conf files from the fluss-dist jar.

Tests

API and Format

Documentation

@wuchong wuchong requested a review from luoyuxia December 14, 2024 13:32
Copy link
Collaborator

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wuchong Thanks for the pr. I left some comments

@@ -51,4 +51,4 @@ logger.netty.level=OFF
logger.jindo_fsStats.name=com.aliyun.jindodata.common.FsStats
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the jindo releated properties since there's no jindo...

<scope>provided</scope>
</dependency>

<dependency>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If remove these dependency in here, fluss-dist wll be build before fluss-lakehouse-paimon, then it'll throw

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:3.6.0:single (opt) on project fluss-dist: Failed to create assembly: Error adding file to archive: /Users/luoyuxia/Project/fluss/fluss-dist/../fluss-lakehouse/fluss-lakehouse-paimon/target/fluss-lakehouse-paimon-0.6-SNAPSHOT.jar -> [Help 1]
` ```
while building..

@wuchong
Copy link
Member Author

wuchong commented Dec 16, 2024

@luoyuxia thanks, comments addressed.

Copy link
Collaborator

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wuchong wuchong merged commit c770262 into alibaba:main Dec 17, 2024
1 of 2 checks passed
@wuchong wuchong deleted the deploy-fluss-dist branch December 17, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants