Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add HTTP2 protocol options to skywalking and otel cluster #1379

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

whalecold
Copy link
Contributor

@whalecold whalecold commented Oct 10, 2024

Ⅰ. Describe what this PR did

add HTTP2 protocol options to skywalking and otel cluster

Ⅱ. Does this pull request fix one issue?

fix #1316

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@johnlanni
Copy link
Collaborator

cc @CH3CHO

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 91 lines in your changes missing coverage. Please review.

Project coverage is 43.23%. Comparing base (ef31e09) to head (616a5d5).
Report is 214 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ingress/kube/configmap/tracing.go 0.00% 91 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1379      +/-   ##
==========================================
+ Coverage   35.91%   43.23%   +7.32%     
==========================================
  Files          69       76       +7     
  Lines       11576    12320     +744     
==========================================
+ Hits         4157     5326    +1169     
+ Misses       7104     6662     -442     
- Partials      315      332      +17     
Files with missing lines Coverage Δ
pkg/ingress/kube/configmap/tracing.go 2.17% <0.00%> (-0.35%) ⬇️

... and 68 files with indirect coverage changes

Copy link
Collaborator

@CH3CHO CH3CHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CH3CHO CH3CHO merged commit 49bb5ec into alibaba:main Oct 18, 2024
8 checks passed
@whalecold whalecold deleted the fix/tracing branch October 18, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

对接 Skywalking 和 OTel 服务时强制为对应的 Cluster 启用 HTTP2 协议
4 participants