Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typo): use the correct bing name for ai-search. #1807

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

maratrixx
Copy link
Contributor

Ⅰ. Describe what this PR did

The ai-search plugin is using the wrong bing engine name, I tried to fix it again.

Ⅱ. Does this pull request fix one issue?

None

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

needReference: true
referenceFormat: "### 数据来源\n%s"
searchFrom:
- type: bing        // note here.
  apiKey: "your-bing-key"
  serviceName: "search-service.dns"
  servicePort: 8080

Ⅴ. Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Feb 24, 2025

CLA assistant check
All committers have signed the CLA.

@maratrixx maratrixx changed the title fix(typo): use the correct bing name. fix(typo): use the correct bing name for ai-search. Feb 24, 2025
@cr7258
Copy link
Collaborator

cr7258 commented Feb 24, 2025

@maratrixx Please sign the Contributor License Agreement.

@maratrixx
Copy link
Contributor Author

@maratrixx Please sign the Contributor License Agreement.

Signed.

Copy link
Collaborator

@CH3CHO CH3CHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.41%. Comparing base (ef31e09) to head (8c4c218).
Report is 310 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1807      +/-   ##
==========================================
+ Coverage   35.91%   43.41%   +7.50%     
==========================================
  Files          69       76       +7     
  Lines       11576    12278     +702     
==========================================
+ Hits         4157     5331    +1174     
+ Misses       7104     6617     -487     
- Partials      315      330      +15     

see 71 files with indirect coverage changes

@CH3CHO CH3CHO merged commit e27d3d0 into alibaba:main Feb 25, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants