-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add plugin start log in sdk #1831
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1831 +/- ##
==========================================
+ Coverage 35.91% 43.41% +7.50%
==========================================
Files 69 76 +7
Lines 11576 12278 +702
==========================================
+ Hits 4157 5331 +1174
+ Misses 7104 6617 -487
- Partials 315 330 +15 |
_plugin_id_: sdqwdacscfqw21
_rules_: ...
... 调整后插件日志格式示例如下:
进一步,在日志中可通过正则提取 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
return types.OnPluginStartStatusFailed | ||
} | ||
} | ||
ctx.vm.log.Error("plugin start successfully") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里应该是 info 级别的日志哈
插件增加一个内置字段
_plugin_id_
,通过打印日志标明插件启动是否成功