chore: load EXTRA_TAGS from plugin .buildrc file to avoid build issue. #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
我在 Linux 上跑报错了：
|
Colstuwjx
force-pushed
the
chore/fix-plugin-makefile-extra-tags-issue
branch
from
2b2af50 to
500f1f4
Compare
改成 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1852 +/- ##
==========================================
+ Coverage 35.91% 43.39% +7.48%
==========================================
Files 69 76 +7
Lines 11576 12301 +725
==========================================
+ Hits 4157 5338 +1181
+ Misses 7104 6629 -475
- Partials 315 334 +19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
改成约定的从插件目录 .buildrc 文件读取 EXTRA_TAGS，而不是让用户再去手动设置这个变量值
Ⅱ. Does this pull request fix one issue?
Fixed #1847
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
本地运行
PLUGIN_NAME=ai-token-ratelimit make build,PLUGIN_NAME=ai-proxy make build即可看出来差别。Ⅴ. Special notes for reviews