chore: remove switch of firstchunk (#6638)

* chore: remove switch of firstchunk * chore: add changeset * feat: add export and modify example
alibaba · Nov 16, 2023 · 5d85418 · 5d85418
1 parent a0df6fa
commit 5d85418
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 15 deletions.
diff --git a/.changeset/popular-shirts-explain.md b/.changeset/popular-shirts-explain.md
@@ -0,0 +1,5 @@
+---
+'@ice/runtime': patch
+---
+
+chore: remove switch of cache first chunk
diff --git a/examples/with-first-chunk-cache-ssr/src/app.tsx b/examples/with-first-chunk-cache-ssr/src/app.tsx
@@ -4,7 +4,4 @@ export default defineAppConfig({
   app: {
     rootId: 'app',
   },
-  cache: {
-    firstChunk: true,
-  },
 });
diff --git a/examples/with-first-chunk-cache-ssr/src/document.tsx b/examples/with-first-chunk-cache-ssr/src/document.tsx
@@ -1,4 +1,4 @@
-import { Meta, Title, Links, Main, Scripts } from 'ice';
+import { Meta, Title, Links, Main, Scripts, FirstChunkCache } from 'ice';
 
 function Document() {
   return (
@@ -13,6 +13,7 @@ function Document() {
       </head>
       <body>
         <Main />
+        <FirstChunkCache />
         <Scripts async />
       </body>
     </html>

diff --git a/packages/ice/src/plugins/web/index.ts b/packages/ice/src/plugins/web/index.ts
@@ -15,6 +15,7 @@ const plugin: Plugin = () => ({
         'Title',
         'Links',
         'Scripts',
+        'FirstChunkCache',
         'Data',
         'Main',
         'usePageAssets',
@@ -24,6 +25,7 @@ const plugin: Plugin = () => ({
         'TitleType',
         'LinksType',
         'ScriptsType',
+        'FirstChunkCacheType',
         'DataType',
         'MainType',
       ],

diff --git a/packages/runtime/src/Document.tsx b/packages/runtime/src/Document.tsx
@@ -208,14 +208,9 @@ export const Main: MainType = (props: React.HTMLAttributes<HTMLDivElement>) => {
   const { appConfig } = useAppContext();
 
   return (
-    <>
-      <div id={appConfig.app.rootId} {...props}>
-        {main}
-      </div>
-      {
-        appConfig.cache?.firstChunk && <FirstChunkCache />
-      }
-    </>
+    <div id={appConfig.app.rootId} {...props}>
+      {main}
+    </div>
   );
 };
 

diff --git a/packages/runtime/src/index.ts b/packages/runtime/src/index.ts
@@ -31,6 +31,7 @@ import {
   Title,
   Links,
   Scripts,
+  FirstChunkCache,
   Main,
   Data,
   usePageAssets,
@@ -112,6 +113,7 @@ export {
   Title,
   Links,
   Scripts,
+  FirstChunkCache,
   Data,
   Main,
   usePageAssets,

diff --git a/packages/runtime/src/types.ts b/packages/runtime/src/types.ts
@@ -67,9 +67,6 @@ export interface AppConfig {
     basename?: string;
     initialEntries?: InitialEntry[];
   };
-  cache?: {
-    firstChunk?: boolean;
-  };
 }
 
 export interface RoutesConfig {