fix: compatible with Win32 when enable onDemand compile (#6466)

* fix: compatible with Win32 when enable onDemand compile * test: add test case
alibaba · Aug 16, 2023 · 5fbf49a · 5fbf49a
1 parent b588f0a
commit 5fbf49a
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/.changeset/empty-penguins-give.md b/.changeset/empty-penguins-give.md
@@ -0,0 +1,5 @@
+---
+'@ice/app': patch
+---
+
+fix: compatible with Win32 when enable onDemand request
diff --git a/examples/with-antd/ice.config.mts b/examples/with-antd/ice.config.mts
@@ -3,6 +3,10 @@ import antd from '@ice/plugin-antd';
 import moment from '@ice/plugin-moment-locales';
 
 export default defineConfig(() => ({
+  server: {
+    onDemand: true,
+    format: 'esm',
+  },
   plugins: [
     antd({
       importStyle: true,

diff --git a/packages/ice/src/service/Runner.ts b/packages/ice/src/service/Runner.ts
@@ -6,6 +6,7 @@ import vm from 'vm';
 import { isNodeBuiltin } from 'mlly';
 import consola from 'consola';
 import lodash from '@ice/bundles/compiled/lodash/index.js';
+import dynamicImport from '../utils/dynamicImport.js';
 
 export interface ModuleResult {
   code?: string;
@@ -244,7 +245,9 @@ class Runner {
   }
 
   async interopedImport(id: string) {
-    const importedModule = await import(id);
+    // If dependency is pre bundled, it will returned as an absolute path,
+    // use dynamic import to get the module otherwise it will cause error of URL scheme in Win32.
+    const importedModule = path.isAbsolute(id) ? await dynamicImport(id) : await import(id);
     if (!this.shouldInterop(id, importedModule)) {
       return importedModule;
     }