feat: support onShellReady options

alibaba · Sep 12, 2024 · ad968d9 · ad968d9
1 parent 58cbbe2
commit ad968d9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/.changeset/brown-forks-kiss.md b/.changeset/brown-forks-kiss.md
@@ -0,0 +1,5 @@
+---
+'@ice/runtime': patch
+---
+
+feat: support onShellReady options
diff --git a/packages/runtime/src/runServerApp.tsx b/packages/runtime/src/runServerApp.tsx
@@ -1,6 +1,6 @@
 import * as React from 'react';
 import type { Location } from 'history';
-import type { OnAllReadyParams } from './server/streamRender.js';
+import type { OnAllReadyParams, OnShellReadyParams } from './server/streamRender.js';
 import type {
   AppContext,
   ServerContext,
@@ -86,10 +86,8 @@ export async function renderToResponse(requestContext: ServerContext, renderOpti
     return new Promise<void>((resolve, reject) => {
       // Send stream result to ServerResponse.
       pipe(res, {
-        onShellReady: () => {
-          onShellReady && onShellReady({
-            renderAssets: [],
-          });
+        onShellReady: (params: OnShellReadyParams) => {
+          onShellReady && onShellReady(params);
         },
         onShellError: async (err) => {
           onShellError && onShellError(err);