Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support first chunk cache #6607

Merged
merged 9 commits into from
Oct 30, 2023

Conversation

answershuto
Copy link
Collaborator

@answershuto answershuto commented Oct 24, 2023

appConfig 增加 cache.firstChunk 用以缓存,打开会渲染 <div dangerouslySetInnerHTML={{ __html: '' }} />

@FuzzyFade
Copy link
Collaborator

OK

@answershuto answershuto added the need review Need Review label Oct 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1e1b543) 79.95% compared to head (c0cf308) 79.94%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release/next    #6607      +/-   ##
================================================
- Coverage         79.95%   79.94%   -0.01%     
================================================
  Files               216      216              
  Lines             18822    18838      +16     
  Branches           2443     2444       +1     
================================================
+ Hits              15049    15060      +11     
- Misses             3742     3747       +5     
  Partials             31       31              
Files Coverage Δ
packages/runtime/src/runServerApp.tsx 75.92% <100.00%> (+0.04%) ⬆️
packages/runtime/src/Document.tsx 90.40% <72.22%> (-1.52%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClarkXia ClarkXia removed their request for review October 27, 2023 07:49
Copy link
Collaborator

@FuzzyFade FuzzyFade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@answershuto answershuto merged commit 81849be into release/next Oct 30, 2023
6 checks passed
@answershuto answershuto deleted the feat/support_first_chunk_cache branch October 30, 2023 08:21
ClarkXia added a commit that referenced this pull request Nov 13, 2023
* feat: support first chunk cache (#6607)

* feat: support first chunk cache

* chore: remove cacheFirstChunk

* chore: modify fcc comment

* feat: add FirstChunkCache function

* feat: add first chunk demo

* chore: modify example

* chore: update lock

* chore: update package

* fix: support transform plugin in speedup mode (#6615)

* fix: support tranform plugin in speedup mode

* chore: lint

* chore: remove log

* chore: modify file name (#6619)

* chore: modify file name

* chore: modify lock

* fix: data loader output (#6622)

* fix: data loader output

* fix: check support let first

* chore: add changelog

* fix(@ice/app): requireHook in createService (#6633)

* fix: assets rule in speedup mode (#6632)

* fix: do not minify assets in public by default (#6631)

* chore: update versions (#6618)

---------

Co-authored-by: 染陌同学 <[email protected]>
Co-authored-by: 水澜 <[email protected]>
Co-authored-by: Linbudu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need review Need Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants