fix: do not minify assets in public by default #6631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/next #6631 +/- ##
=============================================
Coverage 79.95% 79.95%
=============================================
Files 216 216
Lines 18847 18847
Branches 2444 2444
=============================================
Hits 15069 15069
Misses 3747 3747
Partials 31 31 ☔ View full report in Codecov by Sentry. |
luhc228
approved these changes
Nov 7, 2023
chenjun1011
approved these changes
Nov 7, 2023
ClarkXia
added a commit
that referenced
this pull request
Nov 13, 2023
* feat: support first chunk cache (#6607) * feat: support first chunk cache * chore: remove cacheFirstChunk * chore: modify fcc comment * feat: add FirstChunkCache function * feat: add first chunk demo * chore: modify example * chore: update lock * chore: update package * fix: support transform plugin in speedup mode (#6615) * fix: support tranform plugin in speedup mode * chore: lint * chore: remove log * chore: modify file name (#6619) * chore: modify file name * chore: modify lock * fix: data loader output (#6622) * fix: data loader output * fix: check support let first * chore: add changelog * fix(@ice/app): requireHook in createService (#6633) * fix: assets rule in speedup mode (#6632) * fix: do not minify assets in public by default (#6631) * chore: update versions (#6618) --------- Co-authored-by: 染陌同学 <[email protected]> Co-authored-by: 水澜 <[email protected]> Co-authored-by: Linbudu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ice.jsshould not deal with the assets in public by default, it may cause unexpected error when minify JS while it had been already done.