Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove types export #6651

Merged
merged 2 commits into from
Nov 30, 2023
Merged

chore: remove types export #6651

merged 2 commits into from
Nov 30, 2023

Conversation

luhc228
Copy link
Collaborator

@luhc228 luhc228 commented Nov 15, 2023

remove ./types export in typesVersions field to be compatible with /// <reference types="@ice/app/types" /> in scaffolds

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a0df6fa) 80.00% compared to head (68e0c3e) 80.00%.

Additional details and impacted files
@@              Coverage Diff              @@
##           release/next    #6651   +/-   ##
=============================================
  Coverage         80.00%   80.00%           
=============================================
  Files               217      217           
  Lines             18918    18918           
  Branches           2451     2451           
=============================================
  Hits              15136    15136           
  Misses             3751     3751           
  Partials             31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClarkXia ClarkXia requested a review from linbudu599 November 30, 2023 02:17
@ClarkXia ClarkXia added the need review Need Review label Nov 30, 2023
@luhc228 luhc228 merged commit 72fc36c into release/next Nov 30, 2023
6 checks passed
@luhc228 luhc228 deleted the chore/remove-types-export branch November 30, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need review Need Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants