Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace binding package #6663

Merged
merged 25 commits into from
Dec 8, 2023
Merged

feat: replace binding package #6663

merged 25 commits into from
Dec 8, 2023

Conversation

ClarkXia
Copy link
Collaborator

@ClarkXia ClarkXia commented Nov 23, 2023

  • Update rspack to 0.4.0
  • Override options definition for custom props
  • Add @ice/pack-binding

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (5a53814) 79.95% compared to head (5e1ffcb) 79.93%.

Files Patch % Lines
packages/ice/src/bundler/rspack/build.ts 20.00% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release/pack    #6663      +/-   ##
================================================
- Coverage         79.95%   79.93%   -0.02%     
================================================
  Files               218      218              
  Lines             18993    18998       +5     
  Branches           2452     2453       +1     
================================================
+ Hits              15186    15187       +1     
- Misses             3776     3780       +4     
  Partials             31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClarkXia ClarkXia changed the title [WIP] Replace binding package feat: replace binding package Dec 5, 2023
@ClarkXia ClarkXia requested review from luhc228 and chenjun1011 and removed request for luhc228 December 5, 2023 09:24
@ClarkXia ClarkXia added the need review Need Review label Dec 6, 2023
@ClarkXia ClarkXia merged commit a68ff48 into release/pack Dec 8, 2023
6 checks passed
@ClarkXia ClarkXia deleted the fix/binding branch December 8, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need review Need Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants