Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix default document import #6674

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

linbudu599
Copy link
Collaborator

- import { Meta, Title, Links, Main, Scripts } from 'ice';
+ import { Meta, Title, Links, Main, Scripts } from '@ice/runtime';

Import from '@ice/runtime' instead of 'ice' as default document was located in the alias resolution path.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (92157d8) 80.05% compared to head (818ae15) 80.05%.

Additional details and impacted files
@@              Coverage Diff              @@
##           release/next    #6674   +/-   ##
=============================================
  Coverage         80.05%   80.05%           
=============================================
  Files               218      218           
  Lines             18969    18969           
  Branches           2453     2453           
=============================================
  Hits              15185    15185           
  Misses             3753     3753           
  Partials             31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linbudu599 linbudu599 merged commit c73fbab into release/next Nov 29, 2023
6 checks passed
@linbudu599 linbudu599 deleted the fix/fix_default_document branch November 29, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need review Need Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants