Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use built-in split chunks strategy by default #6699

Merged
merged 3 commits into from
Dec 20, 2023
Merged

fix: use built-in split chunks strategy by default #6699

merged 3 commits into from
Dec 20, 2023

Conversation

ClarkXia
Copy link
Collaborator

@ClarkXia ClarkXia commented Dec 18, 2023 •
edited
Loading

  • Use built-in split chunks strategy by default and make config of features works.
  • pre bundle react refresh package.

@ClarkXia ClarkXia added the need review Need Review label Dec 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d193fe) 79.93% compared to head (f08ff45) 79.93%.

Additional details and impacted files 
@@              Coverage Diff              @@
##           release/pack    #6699   +/-   ##
=============================================
  Coverage         79.93%   79.93%           
=============================================
  Files               218      218           
  Lines             19000    19000           
  Branches           2454     2454           
=============================================
  Hits              15188    15188           
  Misses             3781     3781           
  Partials             31       31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

chenjun1011
chenjun1011 reviewed Dec 18, 2023
View reviewed changes
packages/rspack-config/src/splitChunks.ts Outdated

const getChunksStrategy = (rootDir: string) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 lint 错误需要改一下吗？

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@ClarkXia ClarkXia requested a review from chenjun1011 December 19, 2023 08:20
@ClarkXia ClarkXia merged commit dd149e5 into release/pack Dec 20, 2023
6 checks passed
@ClarkXia ClarkXia deleted the fix/splitting-chunk branch December 20, 2023 03:12
@alibaba-github-bot alibaba-github-bot bot mentioned this pull request Dec 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjun1011 chenjun1011 chenjun1011 approved these changes

@luhc228 luhc228 luhc228 approved these changes

Assignees
No one assigned
Labels
need review Need Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ClarkXia @codecov-commenter @chenjun1011 @luhc228