Implemented self-monitoring logic for eBPF-related plugins #1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Takuka0311
requested changes
Oct 11, 2024
messixukejia
requested changes
Oct 11, 2024
Takuka0311
approved these changes
Oct 14, 2024
KayzzzZ
force-pushed
the
ql/dev-selfmonitor-new
branch
2 times, most recently
from
25cab4e
to
c637478
Compare
messixukejia
requested changes
Oct 15, 2024
Takuka0311
requested changes
Oct 18, 2024
KayzzzZ
force-pushed
the
ql/dev-selfmonitor-new
branch
from
43020b6
to
1f59574
Compare
|
|
Takuka0311
approved these changes
Oct 21, 2024
|
|
|
|
|
runner这里有一个label，metric_category需要补一下 |
Signed-off-by: qianlu.kk <[email protected]>
Signed-off-by: qianlu.kk <[email protected]>
KayzzzZ
force-pushed
the
ql/dev-selfmonitor-new
branch
from
1f59574
to
4a0b690
Compare
|
|
||
| const string METRIC_PLUGIN_EBPF_LOSS_KERNEL_EVENTS_TOTAL = "plugin_ebpf_loss_kernel_events_total"; | ||
| const string METRIC_PLUGIN_EBPF_NETWORK_OBSERVER_CONNTRACKER_NUM = "plugin_network_observer_conntracker_num"; | ||
| const string METRIC_PLUGIN_EBPF_NETWORK_OBSERVER_WORKER_HANDLE_EVENTS_TOTAL = "plugin_network_observer_worker_handle_events_total"; |
There was a problem hiding this comment.
命名后面 @Takuka0311 统一按照规范改一次
core/ebpf/eBPFServer.cpp
Outdated
| for (int i = 0; i < int(nami::PluginType::MAX); i ++) { | ||
| if (mPluginProject[i] != "") { | ||
| res += mPluginProject[i]; | ||
| res += ""; |
| /********************************************************** | ||
| * ebpf server | ||
| **********************************************************/ | ||
| const string METRIC_RUNNER_EBPF_START_PLUGIN_TOTAL = "runner_start_plugin_total"; |
There was a problem hiding this comment.
这个指标项看上去更应该是公共的 @Takuka0311
messixukejia
approved these changes
Oct 28, 2024
|
CI失败处理下 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.