[issues#12551] nacos-client modularity problem #12696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12696 +/- ##
=============================================
- Coverage 69.62% 69.60% -0.02%
+ Complexity 9415 9412 -3
=============================================
Files 1275 1275
Lines 41233 41233
Branches 4374 4374
=============================================
- Hits 28707 28702 -5
- Misses 10447 10451 +4
- Partials 2079 2080 +1 see 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
KomachiSion
requested changes
Sep 27, 2024
client/pom.xml
Outdated
| @@ -22,24 +22,24 @@ | |||
| <version>${revision}</version> | |||
| <relativePath>../pom.xml</relativePath> | |||
| </parent> | |||
|
|
|||
There was a problem hiding this comment.
请不要修改缩进， 使用nacos-code-style进行reformat
There was a problem hiding this comment.
已修复，ide忽略了空格差异显示，没感知到
KomachiSion
approved these changes
Sep 30, 2024
KomachiSion
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12551
修正了nacos-client模块化问题
Fixed the nacos-client modularity issue
maven-shade-plugin插件打包时会把gson里的模块化描述文件带过来，导致nacos-client错误的使用了gson的模块化描述文件
When the Maven-shad-plugin plugin was packaged, it brought gson's modular description file to nacos-client, causing NacOS-Client to use gson's modular description file incorrectly