Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support kitex #259

Merged
merged 6 commits into from
Dec 23, 2024
Merged

support kitex #259

merged 6 commits into from
Dec 23, 2024

Conversation

123liuziming
Copy link
Collaborator

related to #159

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.36%. Comparing base (00b3ca4) to head (0fe3511).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #259   +/-   ##
=======================================
  Coverage   82.36%   82.36%           
=======================================
  Files          20       20           
  Lines         845      845           
=======================================
  Hits          696      696           
  Misses        122      122           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@123liuziming 123liuziming changed the title [WIP] support kitex support kitex Dec 20, 2024
@123liuziming
Copy link
Collaborator Author

latestdepth test is fixed in PR #260. So you can ignore it.

@123liuziming 123liuziming requested review from y1yang0 and NameHaibinZhang and removed request for y1yang0 December 20, 2024 08:12
Copy link
Member

@y1yang0 y1yang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good

pkg/rules/kitex/kitex_client_setup.go Outdated Show resolved Hide resolved
pkg/rules/kitex/kitex_propagator.go Show resolved Hide resolved
pkg/rules/kitex/kitex_server_setup.go Outdated Show resolved Hide resolved
pkg/rules/kitex/kitex_trace_carrier.go Outdated Show resolved Hide resolved
@123liuziming 123liuziming merged commit fb6f761 into main Dec 23, 2024
9 checks passed
@123liuziming 123liuziming deleted the feat/kitex branch December 23, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants