Simplify extension demos #306
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @anuraaga, thanks for your contribution. I'm currently on vacation (a long Spring Festival holiday). I will review this patch after I return on February 4th. Alternatively, you may consider requesting other reviewers to review it, though they may also be on vacation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a strawman proposal - feel free to close if you like it less than the current pattern.
I was experimenting with a custom rule in my codebase and was able to set it up with a relative path in the JSON config without a problem. Seeing the examples here, I was curious why they need to use absolute path, but AFAICT, it seems to be because of using
go buildon a single file rather than module. I restructured so the module can be built more simply - becauseruleshas ago.modit doesn't change the fact that rules are not in the instrumented app. Does this seem like a worthwhile cleanup?