Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support check org.apache.commons.beanutils.BeanUtils.copyProperties #589

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

support check org.apache.commons.beanutils.BeanUtils.copyProperties #589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49551a9
support check org.apache.commons.beanutils.BeanUtils.copyProperties
atuowgo Oct 13, 2019
5bcca49
BeanUtils目前只限制copyProperties方法，补充单测
atuowgo Dec 29, 2019
2cf7a1b
目前只限制apache BeanUtils的copyProperties方法
atuowgo Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .../src/main/java/com/alibaba/p3c/pmd/lang/java/rule/other/AvoidApacheBeanUtilsCopyRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,9 @@
*/
public class AvoidApacheBeanUtilsCopyRule extends AbstractXpathRule {
private static final String XPATH =
"//PrimaryPrefix/Name[@Image='BeanUtils.copyProperties' and "
+ "//ImportDeclaration[@ImportedName='org.apache.commons.beanutils.BeanUtils']]";
"//PrimaryPrefix/Name[(@Image='BeanUtils.copyProperties' and "
+ "//ImportDeclaration[@ImportedName='org.apache.commons.beanutils.BeanUtils']) or "
+ "starts-with(@Image,'org.apache.commons.beanutils.BeanUtils.copyProperties.copyProperties')]";

public AvoidApacheBeanUtilsCopyRule() {
setXPath(XPATH);
Expand Down
24 changes: 21 additions & 3 deletions ...t/resources/com/alibaba/p3c/pmd/lang/java/rule/other/xml/AvoidApacheBeanUtilsCopyRule.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://pmd.sourceforge.net/rule-tests https://pmd.sourceforge.io/rule-tests_1_0_0.xsd">

<code-fragment id="use-apache-beanutils-copy"><![CDATA[
<code-fragment id="use-apache-beanutils-copyProperties"><![CDATA[
import java.lang.reflect.InvocationTargetException;
import org.apache.commons.beanutils.BeanUtils;
public class AvoidApacheBeanUtilsCopyRule {
Expand All @@ -15,10 +15,28 @@ public class AvoidApacheBeanUtilsCopyRule {
</code-fragment>

<test-code>
<description>Use Apache BeanUtils copy</description>
<description>Use Apache BeanUtils copyProperties</description>
<expected-problems>1</expected-problems>
<expected-linenumbers>5</expected-linenumbers>
<code-ref id="use-apache-beanutils-copy" />
<code-ref id="use-apache-beanutils-copyProperties" />
</test-code>


<code-fragment id="use-apache-beanutils-other"><![CDATA[
import java.lang.reflect.InvocationTargetException;
import org.apache.commons.beanutils.BeanUtils;
public class AvoidApacheBeanUtilsCopyRule {
public void test(Object a) throws IllegalAccessException, InvocationTargetException, NoSuchMethodException {
BeanUtils.describe (a);
}
}
]]>
</code-fragment>

<test-code>
<description>Use Apache BeanUtils other</description>
<expected-problems>0</expected-problems>
<code-ref id="use-apache-beanutils-other" />
</test-code>


Expand Down