Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 539 #910

Open
wants to merge 6 commits into
base: v2.0.0
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
> We are pleased to present Alibaba Java Coding Guidelines which consolidates the best programming practices over the years from Alibaba Group's technical teams. A vast number of Java programming teams impose demanding requirements on code quality across projects as we encourage reuse and better understanding of each other's programs. We have seen many programming problems in the past. For example, defective database table structures and index designs may cause software architecture flaws and performance risks. Another example is confusing code structures being difficult to maintain. Furthermore, vulnerable code without authentication is prone to hackers’ attacks. To address these kinds of problems, we developed this document for Java developers at Alibaba.

For more information please refer the *Alibaba Java Coding Guidelines*:
- 中文版: *[阿里巴巴Java开发手册](https://github.com/alibaba/p3c/blob/master/%E9%98%BF%E9%87%8C%E5%B7%B4%E5%B7%B4Java%E5%BC%80%E5%8F%91%E6%89%8B%E5%86%8C%EF%BC%88%E8%AF%A6%E5%B0%BD%E7%89%88%EF%BC%89.pdf)*
- 中文版: *[阿里巴巴Java开发手册](https://github.com/alibaba/p3c/blob/master/%E9%98%BF%E9%87%8C%E5%B7%B4%E5%B7%B4Java%E5%BC%80%E5%8F%91%E6%89%8B%E5%86%8C%EF%BC%88%E5%8D%8E%E5%B1%B1%E7%89%88%EF%BC%89.pdf)*
- English Version: *[Alibaba Java Coding Guidelines](https://alibaba.github.io/Alibaba-Java-Coding-Guidelines)*
- 《阿里巴巴Java开发手册》书籍版天猫官方店: *[阿里巴巴Java开发手册最新版](https://detail.tmall.com/item.htm?spm=a1z2e.8325951.feedDetail.4.3315431gklIXe&id=562626792765&ns=1&abbucket=14)*
- 《码出高效》书籍版天猫官方店: *[码出高效:Java开发手册](https://detail.tmall.com/item.htm?spm=a230r.1.14.40.7dee7d6bwpO82U&id=575107529181&ns=1&abbucket=20)*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,9 @@
*/
public class AvoidApacheBeanUtilsCopyRule extends AbstractXpathRule {
private static final String XPATH =
"//PrimaryPrefix/Name[@Image='BeanUtils.copyProperties' and "
+ "//ImportDeclaration[@ImportedName='org.apache.commons.beanutils.BeanUtils']]";
"//PrimaryPrefix/Name[(@Image='BeanUtils.copyProperties' and "
+ "//ImportDeclaration[@ImportedName='org.apache.commons.beanutils.BeanUtils']) or "
+ "starts-with(@Image,'org.apache.commons.beanutils.BeanUtils.copyProperties.copyProperties')]";

public AvoidApacheBeanUtilsCopyRule() {
setXPath(XPATH);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://pmd.sourceforge.net/rule-tests https://pmd.sourceforge.io/rule-tests_1_0_0.xsd">

<code-fragment id="use-apache-beanutils-copy"><![CDATA[
<code-fragment id="use-apache-beanutils-copyProperties"><![CDATA[
import java.lang.reflect.InvocationTargetException;
import org.apache.commons.beanutils.BeanUtils;
public class AvoidApacheBeanUtilsCopyRule {
Expand All @@ -15,10 +15,28 @@ public class AvoidApacheBeanUtilsCopyRule {
</code-fragment>

<test-code>
<description>Use Apache BeanUtils copy</description>
<description>Use Apache BeanUtils copyProperties</description>
<expected-problems>1</expected-problems>
<expected-linenumbers>5</expected-linenumbers>
<code-ref id="use-apache-beanutils-copy" />
<code-ref id="use-apache-beanutils-copyProperties" />
</test-code>


<code-fragment id="use-apache-beanutils-other"><![CDATA[
import java.lang.reflect.InvocationTargetException;
import org.apache.commons.beanutils.BeanUtils;
public class AvoidApacheBeanUtilsCopyRule {
public void test(Object a) throws IllegalAccessException, InvocationTargetException, NoSuchMethodException {
BeanUtils.describe (a);
}
}
]]>
</code-fragment>

<test-code>
<description>Use Apache BeanUtils other</description>
<expected-problems>0</expected-problems>
<code-ref id="use-apache-beanutils-other" />
</test-code>


Expand Down
Binary file added 阿里巴巴Java开发手册(华山版).pdf
Binary file not shown.
Binary file removed 阿里巴巴Java开发手册(详尽版).pdf
Binary file not shown.