Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipeline: separate the model define plugin into 2 lifecycle #331

Open
yorkie opened this issue Jul 10, 2020 · 0 comments
Open

pipeline: separate the model define plugin into 2 lifecycle #331

yorkie opened this issue Jul 10, 2020 · 0 comments
Assignees
@yorkie
Labels
pipeline Idea and discussion to create a pipeline for something

Comments

@yorkie
Copy link
Member

yorkie commented Jul 10, 2020

As for the current model-define plugin, we use the one function to handle the different lifecycles: training and serving, this looks a little complicated to plugin developers. Therefore we want to address the issue by the following:

  1. add an optional new file "inference.js" in every model-define plugin, which will be called when serving.
  2. pass the labelmap to "inference.js".
@yorkie yorkie added the pipeline Idea and discussion to create a pipeline for something label Jul 10, 2020
@yorkie yorkie self-assigned this Jul 10, 2020
@yorkie yorkie mentioned this issue Jul 12, 2020
Closed
10 tasks
yorkie added a commit that referenced this issue Aug 9, 2020
@yorkie
Merge branch 'fix/gh-331' of github.com:alibaba/pipcook into fix/gh-331
23a6bc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yorkie yorkie

Labels
pipeline Idea and discussion to create a pipeline for something
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

daemon: add a inference.js in model-define plugin for inferencing. alibaba/pipcook
1 participant
@yorkie