daemon: add a inference.js in model-define plugin for inferencing. #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycao-qy
reviewed
Jul 22, 2020
| * The inference model. | ||
| * @param recoverPath The model path to be recovered. | ||
| */ | ||
| export default async function inference (recoverPath: string): Promise<any> { |
There was a problem hiding this comment.
Shall we give a type definition for inference function in pipcook-core
|
@yorkie Could you rebase since there are some conflicting files. And what's the status of this PR. Will we give separate PR for each plugin? |
|
Just closing this because we will have a new design for plugin entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the model-define plugin development, and this fixes #331. The rest work is to update all the builtin model-define plugins:
bayesian-classifierdetectron-fasterrcnndetectron-maskrcnnfasttexttensorflow-cycle-gantensorflow-mobilenettensorflow-resnettfjs-mobilenettfjs-simplecnntfjs-lstm