Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2862 improve seata beanPostProcessor order #2875

Open
wants to merge 1 commit into
base: 2021.x
Choose a base branch
from
Open

#2862 improve seata beanPostProcessor order #2875

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...ter-alibaba-seata/src/main/java/com/alibaba/cloud/seata/feign/SeataBeanPostProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,24 @@

import org.springframework.beans.BeansException;
import org.springframework.beans.factory.config.BeanPostProcessor;
import org.springframework.core.Ordered;

/**
* @author xiaojing
*/
public class SeataBeanPostProcessor implements BeanPostProcessor {
public class SeataBeanPostProcessor implements BeanPostProcessor, Ordered {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加这个的含义在哪里，你们实际开发有用到吗

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我们遇到的issue
https://q1rp72ja5q.feishu.cn/docx/EGqBd6GGboiFi4xyPxFcdy6rnwG

原因可以描述为：业务通过A开头的后置处理器间接实例化了FeignHttpClient，导致FeignHttpClient不会被seataBeanPostProcessor代理，这样的话FeignSeataClient就不生效，在feign调用中xid无法透传导致全局事务割裂。

因此建议可以提高下SeataBeanPostProcessor的优先级


private final SeataFeignObjectWrapper seataFeignObjectWrapper;

SeataBeanPostProcessor(SeataFeignObjectWrapper seataFeignObjectWrapper) {
this.seataFeignObjectWrapper = seataFeignObjectWrapper;
}

@Override
public int getOrder() {
return HIGHEST_PRECEDENCE;
}

@Override
public Object postProcessBeforeInitialization(Object bean, String beanName)
throws BeansException {
Expand Down