Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3314, set default nacos server address when spring.config.import enabled. #3508

Merged

Conversation

chickenlj
Copy link
Collaborator

Check #3314 for details.

@CLAassistant
Copy link

CLAassistant commented Nov 27, 2023

CLA assistant check
All committers have signed the CLA.

Comment on lines 92 to 94
/**
* Nacos default server and port.
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code format needs to be adjusted

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any documentation on what the developers can do to meet the project styles?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@ruansheng8 ruansheng8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ruansheng8 ruansheng8 merged commit 35f83e3 into alibaba:2021.x Jan 3, 2024
3 checks passed
@chickenlj chickenlj deleted the fix-2021.x-default-nacos-config-addr branch January 3, 2024 04:57
ruansheng8 pushed a commit to ruansheng8/spring-cloud-alibaba that referenced this pull request Mar 7, 2024
…g.import` enabled. (alibaba#3508)

* fix alibaba#3314, set default nacos server address when config.import enabled.
@chickenlj chickenlj restored the fix-2021.x-default-nacos-config-addr branch July 22, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants