Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] 使用byte-buddy重构agent增强功能,支持重新增强已经加载过的类 #324

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zfyq124
Copy link

@zfyq124 zfyq124 commented Nov 3, 2021

移除javaassit使用byte-buddy重构agent增强的功能 fix issue 226 支持重新增强已经加载过的类

只实现了基础线程的增强,扩展机制的增强与vertx还是开发中。请先review下关于线程池与ForkJoinTask的增强有没有错误

@CLAassistant
Copy link

CLAassistant commented Nov 3, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ oldratlee
❌ zfyq124
You have signed the CLA already but the status is still pending? Let us recheck it.

@oldratlee
Copy link
Member

oldratlee commented Nov 4, 2021

考虑TTL agent的使用方式,

  • jar要独立自包含,即一个jar文件;期望将字节码库shade进来并repackage(防止类冲突/不兼容)
  • 期望jar文件比较小

使用byte-buddy 需要看看这些

支持重新增强已经加载过的类

这个是大家提到多次的需求 👍 @zfyq124

@zfyq124
Copy link
Author

zfyq124 commented Nov 4, 2021

考虑TTL agent的使用方式,

  • jar要独立自包含,即一个jar文件;期望将字节码库shade进来并repackage(防止类冲突/不兼容)

这个已经参考之前javassit方式处理了

  • 期望jar文件比较小

byte-buddy 本身就比较大(大约有3M)会造成新的ttl的交付jar由不足1M增长到4M左右。这个目前我还没有太好的处理方案

使用byte-buddy 需要看看这些

支持重新增强已经加载过的类

这个是大家提到多次的需求 👍 @zfyq124

由于jvm本身的限制我使用包装重写了之前ForkJoinTask的增强方案,这个需要重点关注下

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants