[meshing] export computed bounding box #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almarouk
force-pushed
the
dev/meshingBBox
branch
from
79c7512
to
74f9140
Compare
mugulmd
reviewed
Jul 3, 2023
| @@ -481,6 +520,19 @@ int aliceVision_main(int argc, char* argv[]) | |||
| const double height = hexah[0].z - hexah[4].z; | |||
|
|
|||
| ALICEVISION_LOG_INFO("bounding Box : length: " << length << ", width: " << width << ", height: " << height); | |||
|
|
|||
| // Save bounding box | |||
There was a problem hiding this comment.
I'm not sure we should be saving this bounding box with a custom txt format.
A more standard mesh format (OBJ for instance) would probably be more suited as it would allow opening the bounding box in any 3D software.
There was a problem hiding this comment.
Good remark, but easier to use the same parameters to represent the bbox everywhere.
almarouk
force-pushed
the
dev/meshingBBox
branch
from
c5dafe7
to
4bb4a35
Compare
almarouk
force-pushed
the
dev/meshingBBox
branch
from
4bb4a35
to
aa22b34
Compare
fabiencastan
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be used in meshroom for visualizing the automatically estimated bounding box.
See alicevision/Meshroom#2087