Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add locks for intrinsics #1737

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Add locks for intrinsics #1737

merged 1 commit into from
Sep 9, 2024

Conversation

servantftechnicolor
Copy link
Contributor

@servantftechnicolor servantftechnicolor commented Aug 29, 2024 •
edited
Loading

  • add a lock for optical center (offset) in sfmData per intrinsic
  • add a lock for focal length (scale) in sfmData per intrinsic
  • add a lock for distortion objects in sfmData
  • Use these locks in Bundle Adjustment

@servantftechnicolor servantftechnicolor mentioned this pull request Aug 29, 2024
Merged
@servantftechnicolor servantftechnicolor force-pushed the dev/lockOpticalCenter branch 2 times, most recently from c0b4af8 to 2a82555 Compare August 29, 2024 15:11
@servantftechnicolor servantftechnicolor changed the title Add lock for optical center Add locks for intrinsics Aug 29, 2024
@fabiencastan fabiencastan added this to the 3.3.0 milestone Aug 31, 2024
fabiencastan
fabiencastan requested changes Sep 4, 2024
View reviewed changes
Copy link
Member

@fabiencastan fabiencastan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue with lock distortion in ABC file.

@fabiencastan fabiencastan merged commit c16b844 into develop Sep 9, 2024
3 of 4 checks passed
@fabiencastan fabiencastan deleted the dev/lockOpticalCenter branch September 9, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiencastan fabiencastan fabiencastan approved these changes

@cbentejac cbentejac Awaiting requested review from cbentejac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@servantftechnicolor @fabiencastan