Use ENV for environment variable persistence #1790
Open
+20
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch Dockerfile_centos to use ENV instead of profile.d for persisting environment variables
Switch Dockerfile_centos_deps to use ENV instead of profile.d for persisting environment variables
Switch Dockerfile_ubuntu to use ENV instead of profile.d for persisting environment variables
Switch Dockerfile_ubuntu_deps to use ENV instead of profile.d for persisting environment variables
Revert CPU_CORES change as ENV cannot be dynamically set based on a script.
Revert CPU_CORES change as ENV cannot be dynamically set based on a script.
Revert CPU_CORES change as ENV cannot be dynamically set based on a script.
Revert CPU_CORES change as ENV cannot be dynamically set based on a script.
|
Removed the change to Additionally I believe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per #1789, this PR changes the usage of
/etc/profile.d/alicevision.shas a login script to set environment variables to the dockerENVdirective.Features list
Implementation remarks
This implementation relies on
alicevision.shnot being used elsewhere. It does not appear to ever be copied out of the container/image.